Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove circular import #1516

Merged
merged 3 commits into from
Oct 15, 2023
Merged

fix: remove circular import #1516

merged 3 commits into from
Oct 15, 2023

Conversation

front-end-captain
Copy link
Contributor

Remove circular import

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #1516 (e800a5e) into master (dcaeda4) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #1516   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          53       53           
  Lines        1567     1567           
  Branches      205      205           
=======================================
  Hits         1561     1561           
  Partials        6        6
Files Coverage Δ
src/scope/scope.ts 96.55% <100.00%> (ø)
src/utils/binding_utils.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Jameskmonger
Jameskmonger approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Jameskmonger Jameskmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution @front-end-captain

@Jameskmonger Jameskmonger merged commit 758a6bd into inversify:master Oct 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jameskmonger Jameskmonger Jameskmonger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@front-end-captain @codecov-commenter @Jameskmonger @PodaruDragos